feat: 'Email Salary Slips' bulk action in salary slip list view #1063
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
email salary slips functionality is already covered in tests so not adding any test for this explicitly |
mergify bot
pushed a commit
that referenced
this pull request
Nov 16, 2023
(cherry picked from commit 85f9afd)
mergify bot
pushed a commit
that referenced
this pull request
Nov 16, 2023
(cherry picked from commit 85f9afd)
ruchamahabal
added a commit
that referenced
this pull request
Nov 16, 2023
… (#1065) (cherry picked from commit 85f9afd) Co-authored-by: Rucha Mahabal <[email protected]>
ruchamahabal
added a commit
that referenced
this pull request
Nov 16, 2023
… (#1064) (cherry picked from commit 85f9afd) Co-authored-by: Rucha Mahabal <[email protected]>
frappe-pr-bot
pushed a commit
that referenced
this pull request
Nov 17, 2023
# [14.17.0](v14.16.1...v14.17.0) (2023-11-17) ### Bug Fixes * `get_previous_allocation` return value ([f3761b1](f3761b1)) * show only active employees ([#1026](#1026)) ([#1067](#1067)) ([864de2a](864de2a)) * use `get_all` instead of `get_list` ([89d0681](89d0681)) ### Features * 'Email Salary Slips' bulk action in salary slip list view ([#1063](#1063)) ([#1064](#1064)) ([c114901](c114901)) ### Performance Improvements * index most queried fields in Leave Ledger Entry ([ba325cf](ba325cf)) * limit rows to 1 for cf leave expiry query ([ef31f48](ef31f48))
frappe-pr-bot
pushed a commit
that referenced
this pull request
Nov 17, 2023
# [15.3.0](v15.2.0...v15.3.0) (2023-11-17) ### Bug Fixes * `get_previous_allocation` return value ([3a75e90](3a75e90)) * set frappe hr logo in Navbar Settings for frappehr.com sites only ([#1061](#1061)) ([#1062](#1062)) ([0f59266](0f59266)) * show only active employees ([#1026](#1026)) ([#1068](#1068)) ([bb93127](bb93127)) * use `get_all` instead of `get_list` ([d37756d](d37756d)) ### Features * 'Email Salary Slips' bulk action in salary slip list view ([#1063](#1063)) ([#1065](#1065)) ([f738028](f738028)) ### Performance Improvements * index most queried fields in Leave Ledger Entry ([9f2671a](9f2671a)) * limit rows to 1 for cf leave expiry query ([1db1fc5](1db1fc5))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Payroll Entry sends salary slip emails to all the employees on salary slip submission but if there are a few employees who don't have an email account set or the setup is incorrect during this action, there is no way to retrigger sending emails to such employees
Solution
Added list view action to send salary slip emails in bulk. This will enqueue sending emails for the selected salary slips.
Docs: https://frappehr.com/docs/v14/en/salary-slip#3-4-bulk-email-salary-slips